Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 4.0.0 #179

Draft
wants to merge 386 commits into
base: main
Choose a base branch
from
Draft

Release 4.0.0 #179

wants to merge 386 commits into from

Conversation

tlawrie
Copy link
Member

@tlawrie tlawrie commented Jul 5, 2023

Context

Release 4.0.0 refactor and integration with the new services architecture.

Checklist:

  • Verified in an integrated environment
  • Unit and integration tests passing
  • Semantic HTML with accessibility support
  • No linting, test console, or browser console errors (best effort)
  • JSDoc comment blocks for complex code

PR Review Guidance

Additional Info

@tlawrie tlawrie requested a review from timrbula July 5, 2023 23:29
@tlawrie tlawrie self-assigned this Jul 5, 2023
@gitguardian
Copy link

gitguardian bot commented Jul 5, 2023

⚠️ GitGuardian has uncovered 22 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
10044061 Triggered Generic High Entropy Secret a2d8231 src/ApiServer/fixtures/workflowCompose.js View secret
10044061 Triggered Generic High Entropy Secret a2d8231 src/ApiServer/fixtures/workflowCompose.js View secret
10044061 Triggered Generic High Entropy Secret 15f28b9 src/ApiServer/fixtures/workflowCompose.js View secret
10044061 Triggered Generic High Entropy Secret 15f28b9 src/ApiServer/fixtures/workflowCompose.js View secret
10044061 Triggered Generic High Entropy Secret 75e5f98 src/ApiServer/fixtures/workflowCompose.js View secret
7559794 Triggered Generic High Entropy Secret 6d13daf src/ApiServer/fixtures/workflowCompose.js View secret
7559794 Triggered Generic High Entropy Secret c74a8ed src/ApiServer/fixtures/workflowCompose.js View secret
9340725 Triggered Generic High Entropy Secret 0cedfe5 .env.portforward.local View secret
9340725 Triggered Generic High Entropy Secret 404fd65 .env.portforward.local View secret
10044061 Triggered Generic High Entropy Secret f7c0ffa src/ApiServer/fixtures/workflowCompose.js View secret
7559795 Triggered Generic Private Key 15f28b9 src/ApiServer/fixtures/workflowCompose.js View secret
7559795 Triggered Generic Private Key a2d8231 src/ApiServer/fixtures/workflowCompose.js View secret
7559795 Triggered Generic Private Key 15f28b9 src/ApiServer/fixtures/workflowCompose.js View secret
7559795 Triggered Generic Private Key a2d8231 src/ApiServer/fixtures/workflowCompose.js View secret
9249368 Triggered Docker Credentials 95dbae1 README.md View secret
9249368 Triggered Docker Credentials cab4484 README.md View secret
9249368 Triggered Docker Credentials bf7dbc4 README.md View secret
9249369 Triggered Docker Credentials bf7dbc4 README.md View secret
9249369 Triggered Docker Credentials cab4484 README.md View secret
9249369 Triggered Docker Credentials 95dbae1 README.md View secret
9249369 Triggered Docker Credentials daca62f README.md View secret
7288481 Triggered Generic High Entropy Secret e9fc4d7 src/ApiServer/fixtures/revisions.js View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants