fix: mlx backend fails to compile; publish containers to correct ghcr org - #13
Merged
Merged
Conversation
… org
mlx_server.cpp: replace undefined SPEC with mlx::spec(), keep the
anonymous namespace and mlx namespace inside lemon::backends (the early
} // namespace backends put them at lemon:: scope), and include mlx.h
for the descriptor. The mlx backend is in LEMON_BACKENDS unconditionally,
so every Windows build has been broken since the backend was added -
first surfaced by the Validate New llama.cpp Release run.
build-container.yml: push to ghcr.io/${{ github.repository }} instead of
the stale ghcr.io/lemonade-sdk org, which denies the repo's GITHUB_TOKEN
(permission_denied: The requested installation does not exist).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two CI fixes:
mlx-engine|mlxis inLEMON_BACKENDSunconditionally, butmlx_server.cppreferenced an undefinedSPEC, closednamespace backendsbefore the anonymous/mlxnamespaces (putting them atlemon::scope, mismatching the header'slemon::backends::mlx), and never includedmlx.hfor its descriptor. Verified with a local g++ syntax check.ghcr.io/lemonade-sdk/lemonade/build-environment, which the repo's GITHUB_TOKEN can't write (permission_denied: The requested installation does not exist— failing daily since Aug 6). Now usesghcr.io/${{ github.repository }}.