https://github.com/bonfire-networks/bonfire-app/issues/1651

[ju1m]

This PR makes it so that mix.exs installs flavour if it is different than base_flavour,
base_flavour being the case handled just before that.
This instead of installing flavour if it is different than default_flavour which makes little sense to me here.

Possibly fix partially: #1651

[mayel]

I'm not following the logic here, since the code right above the change handles the possible inclusion of the base_flavour while this code handles the possible inclusion of the current flavour?

[ju1m]

Well, let flavour = "social", then flavour != default_flavour is always false, and thus {flavour_atom, git: "https://github.com/bonfire-networks/#{flavour}", override: true} is never added to the deps.
In other words, there should be two blocks:

1. one to install base_flavour (which is already there),
2. and one to install flavour, when it's different than base_flavour because the base_flavour case is already handled by 1..
   The test whether to include 2. or not must therefore be flavour != base_flavour, not flavour != default_flavour which makes no sense because default_flavour is not what 1. installs.

[mayel]

I got it now, thanks again!