Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed singletons except Engine class & Engine no more relies on nini and ini files #57

Merged
merged 9 commits into from
Jan 16, 2013

Conversation

bonesoul
Copy link
Owner

Configuration Changes

  • Moved ini-file based config-classes from Engine to Sample Game project. Engine is now free of both Nini reference and the ini file itself. The actual game show now do what ever it wants (ie . reading from the ini file) supply parameters to EngineConfig.
  • Moved EngineConfiguration class to Core/Config and renamed as EngineConfig. Also added AudioConfig and GraphicsConfig classes.
  • Renamed Config.cs as SettingsReader.cs.
  • AssetManager is no more singleton and now instead referenced by Game.Services.GetService() request (issue Engine is a singleton without the protections thereof. #43).
  • ChunkStorage and InputManager are no more singletons now.
  • Rasterizer is no more a singleton.
  • Now nothing is singleton except the Engine class itself based on the discussion here: Engine is a singleton without the protections thereof. #43
  • closes Engine is a singleton without the protections thereof. #43.

Singletons

Misc

  • Renamed Game.cs in Game project to SampleGame as it was conflicting with XNA.Game.
  • Removed GeneratedblockStorageTest.cs as it was reduntant.
  • Tests will now check if Engine is already initiated and dispose it first on test startup.
  • Also added Test teardown methods.

Hüseyin Uslu added 9 commits January 15, 2013 17:09
…t. Engine is now free of both Nini reference and the ini file itself. The actual game show now do what ever it wants (ie . reading from the ini file) supply parameters to EngineConfig.

The Engine ctor() will now throw an exception when additional instances created (Discussed in issue #43).
Moved EngineConfiguration class to Core/Config and renamed as EngineConfig. Also added AudioConfig and GraphicsConfig classes.
Renamed Game.cs in Game project to SampleGame as it was conflicting with XNA.Game.
Removed GeneratedblockStorageTest.cs as it was reduntant.
Tests will now check if Engine is already initiated and dispose it first on test startup.
Also added Test teardown methods.
Renamed Config.cs as SettingsReader.cs.
Initial work done for #45.
bonesoul pushed a commit that referenced this pull request Jan 16, 2013
…-stuff

Removed singletons except Engine class & Engine no more relies on nini and ini files
@bonesoul bonesoul merged commit fe33bc7 into develop Jan 16, 2013
@bonesoul bonesoul deleted the config-and-engine-instance-stuff branch January 16, 2013 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Engine is a singleton without the protections thereof.
1 participant