Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor change in README.md ~ make checking pluto #95

Merged
merged 1 commit into from
Jul 15, 2023
Merged

minor change in README.md ~ make checking pluto #95

merged 1 commit into from
Jul 15, 2023

Conversation

czartur
Copy link
Contributor

@czartur czartur commented Jun 21, 2023

There is no rule for 'make check-pluto' but for 'make test'.

there is no rule for make check-pluto, the correct command should be make test
@bondhugula
Copy link
Owner

bondhugula commented Jun 21, 2023

There is a rule now for check-pluto. A check prefix is being used to align with standard convention.

check-pluto: PHONY

@czartur
Copy link
Contributor Author

czartur commented Jun 21, 2023

But it is not present in the stable version 0.11.4.

@bondhugula
Copy link
Owner

But it is not present in the stable version 0.11.4.

But this is the git version far ahead of 0.11.4. What we add here has to be consistent with the current state of the repo.

@czartur
Copy link
Contributor Author

czartur commented Jun 21, 2023

But this is the git version far ahead of 0.11.4. What we add here has to be consistent with the current state of the repo.

I understand, but there are two sections in the readme: one for the stable release and one for the git version.

However, 'make check-pluto' is written in both even if it only works with the dev version.

@bondhugula
Copy link
Owner

But this is the git version far ahead of 0.11.4. What we add here has to be consistent with the current state of the repo.

I understand, but there are two sections in the readme: one for the stable release and one for the git version.

However, 'make check-pluto' is written in both even if it only works with the dev version.

Sorry about that, you are right.

@bondhugula bondhugula self-requested a review July 15, 2023 03:43
Copy link
Owner

@bondhugula bondhugula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@bondhugula bondhugula merged commit eddc385 into bondhugula:master Jul 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants