Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update logr to v1.2.2 and update go.mod to 1.17 #8

Merged
merged 1 commit into from
Jan 1, 2022
Merged

Update logr to v1.2.2 and update go.mod to 1.17 #8

merged 1 commit into from
Jan 1, 2022

Conversation

aledbf
Copy link
Contributor

@aledbf aledbf commented Dec 30, 2021

No description provided.

bombsimon
bombsimon reviewed Jan 1, 2022
View reviewed changes
Copy link
Owner

@bombsimon bombsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I added a comment around what version to require for this module, let me know what you think.

go.mod Outdated Show resolved Hide resolved
bombsimon
bombsimon approved these changes Jan 1, 2022
View reviewed changes
Copy link
Owner

@bombsimon bombsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bombsimon bombsimon merged commit 52223a3 into bombsimon:main Jan 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bombsimon bombsimon bombsimon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aledbf @bombsimon