Fix parallel invocation and also a couple typos per the spellchecker. #20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the tests want to be run in parallel since the test function calls #Parallel. However, this only allows the top-level function to run concurrently. Since there are no other top-level functions in the test, there's no effect and the subtests run serially.
While you still want to call #Parallel at the beginning of the function (so you can write other test functions and have them run parallel too), you need to call it in the #Run closure as well. Each subtest then runs in parallel. As it turns out, the tests are so fast that it makes no difference anyway, but I thought you should see the way to get the subtests running as well. Honestly, dropping concurrency is probably simpler, so feel free to do whatever with this PR.
Some refs:
https://gist.github.com/posener/92a55c4cd441fc5e5e85f27bca008721
https://github.com/moricho/tparallel
(Forgive the spelling corrections, my IDE makes the suggestions and I just accepted them.)