Stop overwriting logger on struct when adding fields #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When adding caller, and for Info logs any other field, don't overwrite the logger on the logrusr struct directly since we only want each individual message to contain this information. To make this easier, also always treat the logger internally as a `logrus.Entry` so we don't need to type cast when using it. This also makes us able to use the public duplication interface when duplicating the logger.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding caller, and for Info logs any other field, don't overwrite the
logger on the logrusr struct directly since we only want each individual
message to contain this information.
To make this easier, also always treat the logger internally as a
logrus.Entryso we don't need to type cast when using it. This alsomakes us able to use the public duplication interface when duplicating
the logger.
Add race detection flag when running tests