Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable twig namespace 'theme' by default in order to easily use custo… #37

Merged
merged 1 commit into from
Oct 17, 2020

Conversation

iamgoodbytes
Copy link
Contributor

Enable twig namespace theme by default in order to use this to overwrite templates more easily out of the box with bolt/forms.

This PR is linked to bolt/forms#18 in bolt/forms

cc @I-Valchev

Copy link
Member

@bobdenotter bobdenotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bobdenotter
Copy link
Member

This actually breaks the installation process:

Run composer recipes at any time to see the status of your Symfony recipes.
Executing script cache:clear --no-warmup [KO]
 [KO]
Script cache:clear --no-warmup returned with error code 1
!!
!!  In FilesystemLoader.php line 92:
!!
!!    The "/Users/bob/Sites/Bolt/myprojectname/public/theme/base-2021" directory
!!    does not exist ("/Users/bob/Sites/Bolt/myprojectname/public/theme/base-2021
!!    ").
!!

I'll see if i can workaround it.

@bobdenotter
Copy link
Member

I had to revert this for now, because it broke the installation process: 2b91bba

Let's see if we can find a better solution for this, @I-Valchev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants