Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace manual copy to clipboard with tiny library #3263

Merged
merged 3 commits into from
Jul 4, 2022

Conversation

I-Valchev
Copy link
Member

@I-Valchev I-Valchev commented Jun 29, 2022

👋 Refactors the Copy filename feature for files, removing ugly hidden input field generation with a tiny library.

I couldn't update package-lock.json without too many unrelated changes because of this error 😔

This version of npm is compatible with lockfileVersion@1, but package-lock.json was generated for lockfileVersion@2. I'll try to do my best with it!

Guessing a different version of npm, but updating it on my end didn't fix it.

Copy link
Member

@bobdenotter bobdenotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks, mate! :-D

(not sure why you'd get that notice about the package-lock.json. If your npm is recent, why would it try to revert it to lockfileVersion@1? 🤔 )

@I-Valchev
Copy link
Member Author

Yeah, strange.. thanks for fixing it here

@bobdenotter bobdenotter merged commit a28f474 into master Jul 4, 2022
@bobdenotter bobdenotter deleted the refactor/replace-code-with-library branch July 4, 2022 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants