Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the hash functionality for tabs instead of pills #3262

Merged
merged 1 commit into from
Jun 30, 2022

Conversation

nestordedios
Copy link
Collaborator

Fixes #3261

I have replace the target data-bs-toggle="pill" by data-bs-toggle="tab" to fix that issue. It seems in our source code we are not using any HTML element with an attribute like data-bs-toggle="pill".

It should be safe to replace

Copy link
Member

@bobdenotter bobdenotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! :-)

@bobdenotter bobdenotter merged commit ef2056d into master Jun 30, 2022
@bobdenotter bobdenotter deleted the fix/hashes-on-urls branch June 30, 2022 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hashes have disappeared from URL when clicking on tabs
2 participants