Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

|image looks in all possible fields #3259

Merged
merged 1 commit into from
Jun 27, 2022

Conversation

I-Valchev
Copy link
Member

👋 Hey!

Fixes #3202

  • In the ImageListField itself, it will now look for any filled image, not just the first one
  • For all ListFieldInterface fields, inc. ImageListField, CollectionField and SetField, it'll look through the entire field with nesting to find the first image that qualifies

Copy link
Member

@bobdenotter bobdenotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @I-Valchev! Thanks for the fix, mate! 👍

(The failing in Cypress is unrelated, we're working on fixing those!)

@bobdenotter bobdenotter merged commit 16cb410 into master Jun 27, 2022
@bobdenotter bobdenotter deleted the bugfix/image-filter-all-fields branch June 27, 2022 16:23
@I-Valchev
Copy link
Member Author

Super 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure |image also looks into Collections to find image
2 participants