Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add non-supported SVG HTML element to HTML Sanitiser #3257

Merged
merged 5 commits into from
Jul 5, 2022
Merged

Add non-supported SVG HTML element to HTML Sanitiser #3257

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6130678
Add non-supported SVG HTML element to HTML Sanitiser
nestordedios Jun 24, 2022
b711ba3
Update src/Utils/Sanitiser.php
bobdenotter Jun 24, 2022
d879895
CS fixes
nestordedios Jun 27, 2022
5d93c0e
Merge branch 'fix/allow-svg-element' of github.com:bolt/core into fix…
nestordedios Jun 27, 2022
5382098
Use different class Type hint to pass PHPStan tests
nestordedios Jun 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/Utils/Sanitiser.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,10 @@ private function getPurifier(): HTMLPurifier
// Allow src tag in iframe for embed fields
$definition->addAttribute('iframe', 'src', 'Text');

// Create non supported elements
$this->createNonSupportedElements($definition, explode(',',$allowedTags));


$this->purifier = new \HTMLPurifier($purifierConfig);

return $this->purifier;
Expand All @@ -69,4 +73,14 @@ public function clean(string $html): string
{
return $this->getPurifier()->purify($html);
}

/**
* Handles the creation of non-supported HTML elements by HTMLPurifier out of the box
*/
private function createNonSupportedElements(\HTMLPurifier_HTMLDefinition $definition, array $allowedTags)
{
if (array_search('svg', $allowedTags)) {
$definition->addElement('svg', 'Block', 'Flow', 'Common');
}
}
}