Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix setting new Fields on Collection. #3200

Merged
merged 1 commit into from
May 9, 2022
Merged

Fix setting new Fields on Collection. #3200

merged 1 commit into from
May 9, 2022

Conversation

vlad-ghita
Copy link
Contributor

Bug observed when previewing a record with collection field.
Only last item in collection was available.

$newFields variable must be initialized outside the loop in order to capture all collection fields.

bobdenotter
bobdenotter approved these changes May 9, 2022
View reviewed changes
Copy link
Member

@bobdenotter bobdenotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! thanks, @vlad-ghita 👍

@bobdenotter bobdenotter merged commit 8ffd416 into bolt:master May 9, 2022
@vlad-ghita vlad-ghita deleted the collection-field-set branch May 9, 2022 17:36
@bobdenotter bobdenotter changed the title Fix setting new fields on collection. Fix setting new Fields on Collection. May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobdenotter bobdenotter bobdenotter approved these changes

Assignees
No one assigned
Labels
🐛 tag: bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vlad-ghita @bobdenotter