Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect JSON for non-specialized MySQL platform instances. #3197

Merged
merged 2 commits into from
May 23, 2022
Merged

Detect JSON for non-specialized MySQL platform instances. #3197

merged 2 commits into from
May 23, 2022

Conversation

vlad-ghita
Copy link
Contributor

Specific corner-case:

I deployed app to platform.sh and $platform object is of basic class MySqlPlatform, not specialized as expected at lines above.

This code handles such scenarios for MySQL(ish) databases.

@vlad-ghita
Copy link
Contributor Author

@bobdenotter

Any ETA for merge & publish?

Thanks!

@bobdenotter
Copy link
Member

Thanks, @vlad-ghita. 👍

Can you run vendor/bin/ecs check src --fix, to fix the Code Style issue?

@vlad-ghita
Copy link
Contributor Author

Fixed.

@vlad-ghita
Copy link
Contributor Author

@bobdenotter

Friendly reminder.

Thanks!

bobdenotter
bobdenotter approved these changes May 23, 2022
View reviewed changes
Copy link
Member

@bobdenotter bobdenotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @vlad-ghita 🙈

@bobdenotter bobdenotter merged commit c344c82 into bolt:master May 23, 2022
@vlad-ghita vlad-ghita deleted the mysql-json-detection branch May 25, 2022 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobdenotter bobdenotter bobdenotter approved these changes

Assignees
No one assigned
Labels
🐛 tag: bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vlad-ghita @bobdenotter