Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make LoginFormAuthenticator compatible with Symfony 5.3 #3028

Merged
merged 1 commit into from
Dec 23, 2021
Merged

Make LoginFormAuthenticator compatible with Symfony 5.3 #3028

merged 1 commit into from
Dec 23, 2021

Conversation

I-Valchev
Copy link
Member

Fixes #3023

@I-Valchev I-Valchev mentioned this pull request Dec 21, 2021
Closed
bobdenotter
bobdenotter approved these changes Dec 21, 2021
View reviewed changes
Copy link
Member

@bobdenotter bobdenotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! 👍

bobvandevijver
bobvandevijver approved these changes Dec 21, 2021
View reviewed changes
Copy link
Contributor

@bobvandevijver bobvandevijver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

But, I have to ask, would it not be easier to just drop Symfony 5.3 and require 5.4 or higher? It would definitely ease the transition to Symfony 6 in the future, as you have at least one deprecated interface less to worry about.

@bobdenotter
Copy link
Member

But, I have to ask, would it not be easier to just drop Symfony 5.3 and require 5.4 or higher?

I think we should definitely do that, but not just yet.. Doing so means we'll bump to PHP ^8.0 as well, which is nice, but i don't want to to it too soon. (case in point: Still quite a few stragglers on Bolt 3.x, to name one thing)

@bobdenotter bobdenotter merged commit 3ffbbd5 into master Dec 23, 2021
@bobdenotter bobdenotter deleted the bugfix/bc-compatibility-5.3 branch December 23, 2021 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobvandevijver bobvandevijver bobvandevijver approved these changes

@bobdenotter bobdenotter bobdenotter approved these changes

Assignees
No one assigned
Labels
☣️ critical 🐛 tag: bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bolt 5.1 is incompatible with Symfony 5.3
3 participants
@I-Valchev @bobdenotter @bobvandevijver