Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deprecation notices especially at the level of the return types #3011

Merged
merged 20 commits into from
Dec 14, 2021
Merged

Fix deprecation notices especially at the level of the return types #3011

merged 20 commits into from
Dec 14, 2021

Conversation

bobdenotter
Copy link
Member

Fixing merge conflicts in PR #3000 by @abdellahramadan

abdellahrk and others added 18 commits December 8, 2021 00:01
@abdellahrk
Fix deprecation notices especially at the level of the return types
4e3e9fc
@abdellahrk
run phpstan checks
9649d5d
@abdellahrk
add .env to gitignore
9588df1
@abdellahrk
remove .env
2320fbc
@abdellahrk
Restore .env file
ce76fcd
@bobdenotter
Update .gitignore
1dd0073
@bobdenotter
Update LoginFormAuthenticatorTest.php
8c56466
@bobdenotter
Merge branch 'issue-fix-deprecations' of https://github.com/abdellahr…
65d3ce9 
…amadan/core into abdellahramadan-issue-fix-deprecations
@bobdenotter
Update LoginFormAuthenticator.php
4042582
@abdellahrk @I-Valchev
Fix deprecation notices especially at the level of the return types
c218d96
@abdellahrk @I-Valchev
run phpstan checks
c7d0a8e
@abdellahrk @I-Valchev
add .env to gitignore
f93bf3b
@abdellahrk @I-Valchev
remove .env
beec0fc
@abdellahrk @I-Valchev
Restore .env file
9aa3dae
@bobdenotter @I-Valchev
Update .gitignore
6616736
@bobdenotter @I-Valchev
Update LoginFormAuthenticatorTest.php
0614c93
@bobdenotter @I-Valchev
Update LoginFormAuthenticator.php
ef11518
@I-Valchev
Merge branch 'abdellahramadan-issue-fix-deprecations' of github.com:b…
4f8efa8 
…olt/core into abdellahramadan-issue-fix-deprecations
@I-Valchev I-Valchev changed the base branch from master to 5.0 December 14, 2021 10:47
@I-Valchev I-Valchev changed the base branch from 5.0 to master December 14, 2021 10:47
I-Valchev
I-Valchev approved these changes Dec 14, 2021
View reviewed changes
Copy link
Member

@I-Valchev I-Valchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ 👍 Nice improvement!

Thanks to @abdellahramadan for the work :-)

@bobdenotter bobdenotter merged commit ec32e32 into master Dec 14, 2021
@bobdenotter bobdenotter deleted the abdellahramadan-issue-fix-deprecations branch December 14, 2021 11:22
@bobdenotter bobdenotter mentioned this pull request Dec 14, 2021
Merged
@abdellahrk
Copy link
Contributor

Thank you too @I-Valchev for every fixes and @bobdenotter 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@I-Valchev I-Valchev I-Valchev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bobdenotter @abdellahrk @I-Valchev