[issue-2901] fix(fixtures): non existent data mapped for fields of type select #2954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbarbin
changed the title
jbarbin
force-pushed
the
bugfix/issue-2901/select-fields-fixtures
branch
2 times, most recently
from
0509087 to
b89f06a
Compare
jbarbin
changed the title
jbarbin
force-pushed
the
bugfix/issue-2901/select-fields-fixtures
branch
from
b89f06a to
dd34798
Compare
bobdenotter
approved these changes
Nov 28, 2021
There was a problem hiding this comment.
Hi @jbarbin,
I've assigned this issue to @Joossensei to review, since he opened the issue that this fixes.
bobdenotter
approved these changes
Dec 3, 2021
There was a problem hiding this comment.
I rebased it on master again. This PR should be good-to-go now. Thanks, @jbarbin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes fix fixtures data for field of type select.
I saw a linked error for fields of type select mapped with a content type. Even if this fiels is not required, there are no empty option. That cause the reported error message for these field even on create content page.
Fixes #2901
Changelog