Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always cache the compiled menus #2886

Merged
merged 6 commits into from
Oct 30, 2021
Merged

Always cache the compiled menus #2886

merged 6 commits into from
Oct 30, 2021

Conversation

bobdenotter
Copy link
Member

Partial redo of PR #2853, in order to divide it in smaller chunks

@bobdenotter bobdenotter mentioned this pull request Oct 26, 2021
Open
@bobdenotter bobdenotter marked this pull request as ready for review October 26, 2021 14:00
I-Valchev
I-Valchev approved these changes Oct 26, 2021
View reviewed changes
Copy link
Member

@I-Valchev I-Valchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Nice

bobdenotter
bobdenotter commented Oct 26, 2021
View reviewed changes
bobdenotter
bobdenotter commented Oct 26, 2021
View reviewed changes
I-Valchev
I-Valchev approved these changes Oct 28, 2021
View reviewed changes
Copy link
Member

@I-Valchev I-Valchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Neat!

nestordedios
nestordedios approved these changes Oct 29, 2021
View reviewed changes
Copy link
Collaborator

@nestordedios nestordedios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@bobdenotter bobdenotter merged commit 8b3ad94 into master Oct 30, 2021
@bobdenotter bobdenotter deleted the cache-backend-menu-always branch October 30, 2021 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nestordedios nestordedios nestordedios approved these changes

@I-Valchev I-Valchev I-Valchev approved these changes

Assignees
No one assigned
Labels
🎩 refactor topic: performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bobdenotter @nestordedios @I-Valchev