Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure admin/developer option is respected #2831

Merged
merged 2 commits into from
Sep 17, 2021

Conversation

bobvandevijver
Copy link
Contributor

When providing a complete add-user command (bin/console bolt:add-user --admin admin admin admin@localhost Admin), the interact method is not called, resulting in the admin and developer options to be completely ignored. By detecting their presence in the execute method as well, the user is created correctly.

Workaround till merged/released is to use the bin/console bolt:add-user --role=ROLE_ADMIN admin admin admin@localhost Admin with the role argument instead.

When providing a complete add-user command (`bin/console bolt:add-user --admin admin admin admin@localhost Admin`), the `interact` method is not called, resulting in the admin and developer options to be completely ignored. By detecting their presence in the `execute` method as well, the user is created correctly.

Workaround till merged/released is to use the `bin/console bolt:add-user --role=ROLE_ADMIN admin admin admin@localhost Admin` with the role argument instead.
Copy link
Member

@I-Valchev I-Valchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bobvandevijver
Copy link
Contributor Author

@I-Valchev I would not do so because (if I'm correct) that would always trigger the interactive role question, even when you provided the admin or developer option.

Copy link
Member

@I-Valchev I-Valchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks, in that case let's roll with this!

Copy link
Member

@bobdenotter bobdenotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just in time for 5.0.2 ;-)

@bobdenotter bobdenotter merged commit 346122d into bolt:master Sep 17, 2021
@bobvandevijver bobvandevijver deleted the patch-2 branch September 17, 2021 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants