Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show memory_limit and attempt to set in on CLI #2823

Merged
merged 3 commits into from
Sep 15, 2021

Conversation

bobdenotter
Copy link
Member

Try to set memory_limit on the CLI to help out with memory limits, to turn this:

Schermafbeelding 2021-09-07 om 09 38 25

into:

Schermafbeelding 2021-09-07 om 09 38 54

Also show the memory limit on /about and bin/console b:i:

afbeelding

afbeelding

@bobdenotter bobdenotter added the topic: DX Improving code quality, tests coverage, making codebase more intuitive label Sep 7, 2021
Copy link
Member

@I-Valchev I-Valchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Great improvement, @bobdenotter !

@eduardomart
Copy link
Contributor

Hi @bobdenotter I did as you recommended, and increase PHP memory_limit to 256MB and when running bin/console c:c it does it without problems now.

I noticed this post come up in Slack, I am wondering if this is related, when I clear the cache using Bolt's backend I get this:

// Clearing the cache for the dev environment with debug                       
 // true                                                                        

00:03:43 DEBUG     [php] Warning: file(/proc/mounts): failed to open stream: No such file or directory
[
  "exception" => Symfony\Component\ErrorHandler\Exception\SilencedErrorContext {
    +count: 1
    -severity: E_WARNING
    trace: {
      /Users/eduardo/Sites/bolt5/vendor/symfony/framework-bundle/Command/CacheClearCommand.php:211 { …}
      /Users/eduardo/Sites/bolt5/vendor/symfony/framework-bundle/Command/CacheClearCommand.php:164 { …}
    }
  }
]
 // Removing old build and cache directory...                                   

 // Finished                                                                    

 [OK] Cache for the "dev" environment (debug=true) was successfully cleared.

@bobdenotter
Copy link
Member Author

@eduardomart Not sure if it's related.. Sounds like a restrction in the server setup.. Does it work otherwise, if you ignore the warning?

@bobdenotter bobdenotter merged commit d3132ae into 4.2 Sep 15, 2021
@bobdenotter bobdenotter deleted the fix/set-and-show-memory-limit branch September 15, 2021 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: DX Improving code quality, tests coverage, making codebase more intuitive
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants