Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unlimited select field options #2750

Merged
merged 1 commit into from
Aug 11, 2021
Merged

Unlimited select field options #2750

merged 1 commit into from
Aug 11, 2021

Conversation

JTNMW
Copy link
Contributor

@JTNMW JTNMW commented Aug 4, 2021

Allows the number of options displayed in select fields to be set by the limit value in the contenttypes.yaml

Allows the number of options displayed in select fields to be set by the limit value in the contenttypes.yaml
@bobdenotter
Copy link
Member

Hi @JTNMW,

CI seems to be complaining about the line with optionsLimit, because it disapproves of CamelCase. I wonder if it's treated as case sensitive, or if we could just use optionslimit there too? 🤔

@JTNMW
Copy link
Contributor Author

JTNMW commented Aug 6, 2021

hi @bobdenotter ,

I followed the syntax given in the vue-multiselect documentation https://vue-multiselect.js.org/#sub-props. I'm not sure how strict these need to be followed. I'll give it a go in lower case and let you know if i still get the same results.

Copy link
Member

@I-Valchev I-Valchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid, thanks @JTNMW.

If you would like to also introduce the autocomplete option in 4.2, I'd suggest checking here: https://github.com/bolt/core/pull/2727/files

A few things are missing in the current PR. It maybe best to not introduce this here and, instead, create a separate PR that makes the autocomplete work for 4.2 :-)

@bobdenotter
Copy link
Member

Thanks, @JTNMW 👍

Let's roll with this!

It maybe best to not introduce this here and, instead, create a separate PR that makes the autocomplete work for 4.2 :-)

If we feel we should backport fixes, let's do so in a separate PR!

@bobdenotter bobdenotter merged commit d6bb476 into bolt:4.2 Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants