Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass around BaseExtension instead of string in ExtensionsConfigureCommand #2628

Merged
merged 1 commit into from
Jun 14, 2021
Merged

Pass around BaseExtension instead of string in ExtensionsConfigureCommand #2628

merged 1 commit into from
Jun 14, 2021

Conversation

bobdenotter
Copy link
Member

Fixes #2627

I-Valchev
I-Valchev approved these changes Jun 14, 2021
View reviewed changes
Copy link
Member

@I-Valchev I-Valchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈 Oh, that's my mistake!

👍

mcdennem
mcdennem approved these changes Jun 14, 2021
View reviewed changes
Copy link
Member

@mcdennem mcdennem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mcdennem mcdennem merged commit b7de90f into 4.1 Jun 14, 2021
@mcdennem mcdennem deleted the fix/pass-BaseExtension branch June 14, 2021 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcdennem mcdennem mcdennem approved these changes

@I-Valchev I-Valchev I-Valchev approved these changes

Assignees
No one assigned
Labels
🐛 tag: bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error in extensions:configure command
3 participants
@bobdenotter @I-Valchev @mcdennem