Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy packaged themes in bolt:copy-themes command #2563

Merged
merged 3 commits into from
May 11, 2021

Conversation

I-Valchev
Copy link
Member

When running php bin/console bolt:copy-themes, it will also copy any themes that are installed as extensions.

@bobdenotter It should work as-is, but I wasn't able to test it because of version constraints. Maybe you have an idea of how to verify that it works?

@I-Valchev I-Valchev changed the base branch from 4.1 to 4.2 May 10, 2021 11:15
@I-Valchev I-Valchev changed the base branch from 4.2 to 4.1 May 10, 2021 11:15
Copy link
Member

@bobdenotter bobdenotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but let's be sure to test it in the field before 5.0.0 stable.

As an additional feature, would it be nice if you could run bin/console bolt:copy:themes name-of-theme, to just copy that one theme?

@bobdenotter bobdenotter merged commit 8b63b94 into 4.1 May 11, 2021
@bobdenotter bobdenotter deleted the bugfix/copy-themes-packages branch May 11, 2021 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants