allow rel attribute by default #2064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow rel attribute when sanitize HTML Same proposition for Bolt 4 as made here --> bolt/bolt#7885 for Bolt 3.7 As the ckeditor link options have 'rel' tags in there 'advanced' tab it would be a good idea to allow rel tag by default/ Because it's a bit confusing for the user to be allowed to add the tag but to not store it in the database. (see discussion here (talking about 3.7) --> https://boltcms.slack.com/archives/C094GL7ME/p1603187487310500)
bobdenotter
reviewed
Oct 27, 2020
bobdenotter
approved these changes
Oct 27, 2020
There was a problem hiding this comment.
@scaphandroid Thanks! i've added two more, and am going to merge in! 👍
|
Merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow rel attribute when sanitize HTML
Same proposition for Bolt 4 as made here --> bolt/bolt#7885 for Bolt 3.7
As the ckeditor link options have 'rel' tags in there 'advanced' tab it would be a good idea to allow rel tag by default/ Because it's a bit confusing for the user to be allowed to add the tag but to not store it in the database.
(see discussion here (talking about 3.7) --> https://boltcms.slack.com/archives/C094GL7ME/p1603187487310500)