Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[composer] decouple post-install/update-cmd and skip run on CI #1961

Merged
merged 2 commits into from
Oct 8, 2020
Merged

[composer] decouple post-install/update-cmd and skip run on CI #1961

merged 2 commits into from
Oct 8, 2020

Conversation

TomasVotruba
Copy link
Contributor

@TomasVotruba TomasVotruba commented Oct 7, 2020 •
edited
Loading

Implementing #1918 (comment)

@TomasVotruba TomasVotruba force-pushed the tv-ci-only-skip-scripts branch 3 times, most recently from b4a3135 to afdfdfe Compare October 7, 2020 23:06
@TomasVotruba TomasVotruba force-pushed the tv-ci-only-skip-scripts branch from afdfdfe to 0e651a1 Compare October 7, 2020 23:07
@TomasVotruba
Copy link
Contributor Author

Ready to merge 👍

Could someone verify this branch composer install work correctly for all the user-experience setup?

bobdenotter
bobdenotter approved these changes Oct 8, 2020
View reviewed changes
Copy link
Member

@bobdenotter bobdenotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could someone verify this branch composer install work correctly for all the user-experience setup?

I've monkey-tested this on my setups, and it works fine! 👍

@bobdenotter bobdenotter merged commit 3b6f145 into bolt:master Oct 8, 2020
@bobdenotter bobdenotter added the topic: DX Improving code quality, tests coverage, making codebase more intuitive label Oct 8, 2020
@bobdenotter bobdenotter changed the title [composer] decouple post-install/update-cmd and skip run on CI [composer] decouple post-install/update-cmd and skip run on CI Oct 8, 2020
@TomasVotruba TomasVotruba deleted the tv-ci-only-skip-scripts branch October 8, 2020 10:23
@TomasVotruba TomasVotruba mentioned this pull request Oct 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobdenotter bobdenotter bobdenotter approved these changes

Assignees
No one assigned
Labels
topic: DX Improving code quality, tests coverage, making codebase more intuitive
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TomasVotruba @bobdenotter