API: $this->viewlessContentTypes should be a indexed array, not associative
#1960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… return an associative array, and this in turn messes up the parameter substitution in SQLParserUtils.expandListParameters(). Using values() instead of toArray() fixes this. fixes bolt#1953
|
I can confirm, that this fixes the issue from #1953 Simon already explained the problem in the issue nicely. |
bobdenotter
approved these changes
Oct 8, 2020
bobdenotter
changed the title
$this->viewlessContentTypes should be a indexed array, not associative
|
Thanks for the bug fix! Much appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this fixes #1953