Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Move console checks from Travis to Github Actions #1917

Merged
merged 4 commits into from
Sep 28, 2020

Conversation

TomasVotruba
Copy link
Contributor

@TomasVotruba TomasVotruba commented Sep 28, 2020

Follow up to #1916

@TomasVotruba TomasVotruba marked this pull request as ready for review September 28, 2020 12:12
@TomasVotruba
Copy link
Contributor Author

Ready to merge ✔️

@TomasVotruba TomasVotruba changed the title [CI] Move console checks from Travais to Github Actions [CI] Move console checks from Travis to Github Actions Sep 28, 2020
@bobdenotter bobdenotter merged commit 416129c into bolt:master Sep 28, 2020
@TomasVotruba TomasVotruba deleted the github-actions-3 branch September 28, 2020 14:34
@TomasVotruba
Copy link
Contributor Author

Thank you 👍

Btw, do you any questions or WTFs in your mind?
I want this transition to be clear and safe to you, so don't hesitate and ask about any single silly weird line you see.

@bobdenotter
Copy link
Member

So far it seems straightforward! I suppose the "tricky" part will be Behat. It's the part that fails most often on Travis for dubious reasons, and if I recall correctly, it was also the most complex to get working.

Tomorrow @I-Valchev will be at work again, so i'm sure he'll chime in as well! :-)

@TomasVotruba
Copy link
Contributor Author

TomasVotruba commented Sep 28, 2020

That's great, I never worked with Behat so that should not be a problem ;)


I see some first complications - https://github.com/bolt/core/runs/1177089242

It might be caused by incorrect composer.json setup:

       "post-install-cmd": [
            "php bin/console extensions:configure --with-config",
            "@auto-scripts",
            "php bin/console bolt:info"
        ],
        "pre-package-uninstall": [
            "php bin/console extensions:configure --remove-services"
        ],
        "post-update-cmd": [
            "php bin/console extensions:configure",
            "@auto-scripts",
            "php bin/console bolt:info"
        ],
        "auto-scripts": {
            "cache:clear --no-warmup": "symfony-cmd",
            "assets:install --symlink --relative %PUBLIC_DIR%": "symfony-cmd"
        },

This is seems like a project composer.json, e.g symfony/demo or laravel/laravel

I've found these lines in bolt/project

Saying that, what are those needed for here?

@I-Valchev
Copy link
Member

@TomasVotruba @bobdenotter Yes I also think it's pretty clear and understandable. Good to know that we have console colours by adding --ansi. Thanks Tomas!

@bobdenotter bobdenotter added the topic: DX Improving code quality, tests coverage, making codebase more intuitive label Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: DX Improving code quality, tests coverage, making codebase more intuitive
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants