Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Notice: Array to string conversion in Field.php by ensuring the array is one level deep. #1811

Merged
merged 2 commits into from
Sep 2, 2020
Merged

Fix Notice: Array to string conversion in Field.php by ensuring the array is one level deep. #1811

merged 2 commits into from
Sep 2, 2020

Conversation

bobdenotter
Copy link
Member

This happens for fields that don't implement their own __toString() method, like type: data, or potentially Fields added by extensions.

Schermafbeelding 2020-09-02 om 11 24 47

bobdenotter
bobdenotter commented Sep 2, 2020
View reviewed changes
src/Entity/Field.php Outdated Show resolved Hide resolved
I-Valchev
I-Valchev approved these changes Sep 2, 2020
View reviewed changes
Copy link
Member

@I-Valchev I-Valchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! 👍

@I-Valchev I-Valchev merged commit 74e77e5 into master Sep 2, 2020
@I-Valchev I-Valchev deleted the bobdenotter-patch-2 branch September 2, 2020 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@I-Valchev I-Valchev I-Valchev approved these changes

Assignees
No one assigned
Labels
🐛 tag: bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bobdenotter @I-Valchev