Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use current filter to check if menu item is this page #1659

Merged
merged 4 commits into from
Jul 30, 2020
Merged

Use current filter to check if menu item is this page #1659

merged 4 commits into from
Jul 30, 2020

Conversation

I-Valchev
Copy link
Member

Fixes #1655
Use |current and not .current

@I-Valchev I-Valchev mentioned this pull request Jul 29, 2020
Closed
@I-Valchev I-Valchev changed the title Use current filter to check if menu item is this page [WIP] Use current filter to check if menu item is this page Jul 29, 2020
ymarkus
ymarkus suggested changes Jul 29, 2020
View reviewed changes
Copy link
Contributor

@ymarkus ymarkus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix, after one additional change (see my comment) it works perfectly now!

src/Twig/FrontendMenuExtension.php Outdated Show resolved Hide resolved
@ymarkus
Copy link
Contributor

ymarkus commented Jul 30, 2020

Tested with the current master branch and it works fine! Thanks @I-Valchev!

bobdenotter
bobdenotter approved these changes Jul 30, 2020
View reviewed changes
Copy link
Member

@bobdenotter bobdenotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

(i'm making a mental note to update the bolt/themes repo accordingly)

@bobdenotter bobdenotter merged commit f6ee744 into master Jul 30, 2020
@bobdenotter bobdenotter deleted the bugfix/menu-current branch July 30, 2020 08:22
@I-Valchev I-Valchev changed the title [WIP] Use current filter to check if menu item is this page Use current filter to check if menu item is this page Jul 30, 2020
@ymarkus ymarkus mentioned this pull request Jul 31, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ymarkus ymarkus ymarkus requested changes

@bobdenotter bobdenotter bobdenotter approved these changes

Assignees
No one assigned
Labels
🐛 tag: bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

{{ item|current }} or {{ item.current }} not working
3 participants
@I-Valchev @ymarkus @bobdenotter