Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix capitalisation in groups #1479

Merged
merged 3 commits into from
Jun 15, 2020
Merged

Fix capitalisation in groups #1479

merged 3 commits into from
Jun 15, 2020

Conversation

bobdenotter
Copy link
Member

Fixes #1473

@I-Valchev
Copy link
Member

@bobdenotter could we keep the first letter capitalization by default? It's kind of nice, I think.

@bobdenotter
Copy link
Member Author

@I-Valchev You're right, but using ucfirst will capitalize every word, including things like a and the. I've now added a method to bolt/common that does this much more nicely:

Screenshot 2020-06-15 at 15 59 28

@I-Valchev
Copy link
Member

That's cool, I like it!

I-Valchev
I-Valchev approved these changes Jun 15, 2020
View reviewed changes
Copy link
Member

@I-Valchev I-Valchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚂🚃🚃

@I-Valchev I-Valchev merged commit 41a94bf into master Jun 15, 2020
@I-Valchev I-Valchev deleted the bobdenotter-patch-1 branch June 15, 2020 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@I-Valchev I-Valchev I-Valchev approved these changes

Assignees
No one assigned
Labels
🐛 tag: bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Contenttypes field group text are always capitilized in edit page
2 participants
@bobdenotter @I-Valchev