Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add todo to stop selenium server process #1393

Merged
merged 4 commits into from
May 22, 2020
Merged

Add todo to stop selenium server process #1393

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5c656fd
Add todo to stop selenium server process
I-Valchev May 22, 2020
992f089
Update Makefile
I-Valchev May 22, 2020
fe705cb
Fix indentation
I-Valchev May 22, 2020
fe8143c
Make sure PATH stays
I-Valchev May 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,23 +76,22 @@ behat-api-quiet: ## to run behat API tests quietly
behat-js: ## to run behat JS tests
make server
echo "Running Behat e2e tests. Make sure you have the latest version of Google Chrome installed"
## If not already in path, add vendor/bin/ to it, where chromedriver executable can be found.
[ ":${PATH}:" != *":$(pwd)/vendor/bin:"* ] && PATH="$(pwd)/vendor/bin:${PATH}"
. ./run_behat_tests.sh
## run the selenium server. chromedriver executable must be in $PATH
vendor/bin/selenium-server-standalone >/dev/null 2>&1 &
sleep 2s
vendor/bin/behat --tags=javascript
# kill -9 $(lsof -t -i:4444)
## @todo: stop selenium server

behat-js-quiet: ## to run behat JS tests quietly
make server
echo "Running Behat e2e tests. Make sure you have the latest version of Google Chrome installed"
./run_behat_tests.sh
. ./run_behat_tests.sh
## run the selenium server. chromedriver executable must be in $PATH
vendor/bin/selenium-server-standalone >/dev/null 2>&1 &
sleep 2s
vendor/bin/behat --tags=javascript --format=progress
# kill -9 $(lsof -t -i:4444)
## @todo: stop selenium server

behat:
make behat-api
Expand Down