Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Persist non-translatable field with correct default locale #1384

Merged
merged 5 commits into from
May 18, 2020
Merged

Persist non-translatable field with correct default locale #1384

merged 5 commits into from
May 18, 2020

Conversation

I-Valchev
Copy link
Member

So far all non-translatable fields were persisted with locale en.

In this PR, the fields are persisted with the provided locale from services.yaml

bobdenotter
bobdenotter approved these changes May 18, 2020
View reviewed changes
Copy link
Member

@bobdenotter bobdenotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And it even has less lines of code!

@bobdenotter bobdenotter merged commit d0ee0aa into master May 18, 2020
@bobdenotter bobdenotter deleted the inject-field-default-locale branch May 18, 2020 14:26
@I-Valchev
Copy link
Member Author

wow I'm shocked myself!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobdenotter bobdenotter bobdenotter approved these changes

Assignees
No one assigned
Labels
🐛 tag: bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@I-Valchev @bobdenotter