Skip to content

Commit

Permalink
Merge pull request #1520 from bolt/bugfix/prepopulate-sets-inside-col…
Browse files Browse the repository at this point in the history
…lections-correctly

Make sure sets inside collections are instantiated with actual values
  • Loading branch information
bobdenotter authored Jun 19, 2020
2 parents 915c0b2 + 9c837ba commit a999870
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions src/Event/Listener/FieldFillListener.php
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,11 @@ public function postLoad(LifecycleEventArgs $args): void
public function fillSet(SetField $entity): void
{
$definition = $entity->getDefinition();
$fields = $this->intersectFieldsAndDefinition($this->fields->findAllByParent($entity), $definition);
$fields = $this->fields->findAllByParent($entity);

/** @var Field $field */
foreach ($fields as $field) {
$definition = $entity->getDefinition()->get('fields')[$field->getName()] ?? new Collection();
$definition = $definition->get('fields')[$field->getName()] ?? new Collection();
$field->setDefinition($field->getName(), $definition);
}

Expand Down
2 changes: 1 addition & 1 deletion templates/_partials/fields/image.html.twig
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{% extends '@bolt/_partials/fields/_base.html.twig' %}

{% set extensions = field.definition.get('extensions')|default('') %}
{% set extensions = field.definition.get('extensions')|default([]) %}
{% set info %}
{{ 'upload.allow_file_types'|trans }}: <code>{{ extensions|join('</code>, <code>') }}</code><br>
{{ 'upload.max_size'|trans }}: {{ config.maxupload|format_bytes }}
Expand Down

0 comments on commit a999870

Please sign in to comment.