Skip to content

Commit

Permalink
Merge pull request #1393 from bolt/todo-stop-selenium
Browse files Browse the repository at this point in the history
Add todo to stop selenium server process
  • Loading branch information
bobdenotter authored May 22, 2020
2 parents dd2049a + fe8143c commit 2c7541a
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -76,23 +76,22 @@ behat-api-quiet: ## to run behat API tests quietly
behat-js: ## to run behat JS tests
make server
echo "Running Behat e2e tests. Make sure you have the latest version of Google Chrome installed"
## If not already in path, add vendor/bin/ to it, where chromedriver executable can be found.
[ ":${PATH}:" != *":$(pwd)/vendor/bin:"* ] && PATH="$(pwd)/vendor/bin:${PATH}"
. ./run_behat_tests.sh
## run the selenium server. chromedriver executable must be in $PATH
vendor/bin/selenium-server-standalone >/dev/null 2>&1 &
sleep 2s
vendor/bin/behat --tags=javascript
# kill -9 $(lsof -t -i:4444)
## @todo: stop selenium server

behat-js-quiet: ## to run behat JS tests quietly
make server
echo "Running Behat e2e tests. Make sure you have the latest version of Google Chrome installed"
./run_behat_tests.sh
. ./run_behat_tests.sh
## run the selenium server. chromedriver executable must be in $PATH
vendor/bin/selenium-server-standalone >/dev/null 2>&1 &
sleep 2s
vendor/bin/behat --tags=javascript --format=progress
# kill -9 $(lsof -t -i:4444)
## @todo: stop selenium server

behat:
make behat-api
Expand Down

0 comments on commit 2c7541a

Please sign in to comment.