Skip to content

Commit

Permalink
Merge pull request #1904 from eduardomart/collection-card-body
Browse files Browse the repository at this point in the history
Collection updates
bobdenotter authored Sep 27, 2020

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
2 parents 47eb1c0 + c0b014a commit 155a1dc
Showing 3 changed files with 4 additions and 6 deletions.
5 changes: 4 additions & 1 deletion assets/scss/modules/editor/fields/_collection.scss
Original file line number Diff line number Diff line change
@@ -45,7 +45,10 @@

.card-body {
background: var(--background);
padding-bottom: 0;
// 1px solves the ghosted whitespace
// @see https://github.com/bolt/core/pull/1904

padding-bottom: 1px;
}
}
}
4 changes: 0 additions & 4 deletions templates/_partials/fields/_label.html.twig
Original file line number Diff line number Diff line change
@@ -8,10 +8,6 @@

<label for="{{ id }}" class="editor--label{% if type|default() == 'collection' %} sr-only{% endif %}">

{% if in_compound is defined %}
<span style="font-weight: normal;">{{ compound_label }} &raquo;</span>
{% endif %}

{{- label -}}:
{% if required %} <span class="required-label"></span> {% endif %}

1 change: 0 additions & 1 deletion tests/e2e/edit_record_1.feature
Original file line number Diff line number Diff line change
@@ -188,7 +188,6 @@ Feature: Edit record

When I follow "Sets"
Then I should be on "/bolt/edit/43#sets"
And I should see "This is my set" in the "#sets label[for='field-set-title']" element

And I should see "Title" in the "#sets label[for='field-set-title']" element
And I should see exactly one "sets[set][title]" element

0 comments on commit 155a1dc

Please sign in to comment.