Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds support for vw, vh unit for maxHeight, maxWidth #526

Merged
merged 2 commits into from
Sep 27, 2019

Conversation

hhvys
Copy link

@hhvys hhvys commented Sep 25, 2019

resolves #525

Copy link
Owner

@bokuweb bokuweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great :) if you are ok, could you please add test case with vh/vw?

@bokuweb
Copy link
Owner

bokuweb commented Sep 25, 2019

@hhvys Sorry, could you update README.md too?

@hhvys
Copy link
Author

hhvys commented Sep 26, 2019

Great :) if you are ok, could you please add test case with vh/vw?

Sorry, test will require #content value in fixture.html to change. If possible merge without test.
Thanks

@bokuweb
Copy link
Owner

bokuweb commented Sep 26, 2019

@hhvys Thanks. I see. Ok Please could you update update only README? if done I'll merge it :)

@bokuweb bokuweb merged commit 9a67c44 into bokuweb:master Sep 27, 2019
@hhvys hhvys deleted the feat/525 branch September 27, 2019 05:56
@bokuweb
Copy link
Owner

bokuweb commented Sep 28, 2019

@hhvys v6.1.0 just published 🎉 Thanks for your work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for vw, vh unit for maxWidth, maxHeight
2 participants