Skip to content

Commit

Permalink
fix: fix CLI_ARGS completion for fish and zsh (go-task#1843)
Browse files Browse the repository at this point in the history
  • Loading branch information
boiledfroginthewell committed Sep 29, 2024
1 parent ad5a316 commit 69906b5
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 8 deletions.
6 changes: 4 additions & 2 deletions completion/fish/task.fish
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,10 @@ function __task_get_tasks --description "Prints all available tasks with their d
end
end

complete -c $GO_TASK_PROGNAME -d 'Runs the specified task(s). Falls back to the "default" task if no task name was specified, or lists all tasks if an unknown task name was
specified.' -xa "(__task_get_tasks)"
complete -c $GO_TASK_PROGNAME \
-d 'Runs the specified task(s). Falls back to the "default" task if no task name was specified, or lists all tasks if an unknown task name was specified.' \
-xa "(__task_get_tasks)" \
-n "not __fish_seen_subcommand_from --"

complete -c $GO_TASK_PROGNAME -s c -l color -d 'colored output (default true)'
complete -c $GO_TASK_PROGNAME -s d -l dir -d 'sets directory of execution'
Expand Down
20 changes: 14 additions & 6 deletions completion/zsh/_task
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,13 @@ function __task_list() {
taskfile=${(Qv)opt_args[(i)-t|--taskfile]}
taskfile=${taskfile//\~/$HOME}

for arg in "${words[@]:0:$CURRENT}"; do
if [[ "$arg" = "--" ]]; then
# Use default completion for words after `--` as they are CLI_ARGS.
_default
return 0
fi
done

if [[ -n "$taskfile" && -f "$taskfile" ]]; then
enabled=1
Expand All @@ -40,6 +47,7 @@ function __task_list() {

_task() {
_arguments \
-S \
'(-C --concurrency)'{-C,--concurrency}'[limit number of concurrent tasks]: ' \
'(-p --parallel)'{-p,--parallel}'[run command-line tasks in parallel]' \
'(-f --force)'{-f,--force}'[run even if task is up-to-date]' \
Expand All @@ -55,13 +63,13 @@ _task() {
'(-t --taskfile)'{-t,--taskfile}'[specify a different taskfile]:taskfile:_files' \
'(-v --verbose)'{-v,--verbose}'[verbose mode]' \
'(-w --watch)'{-w,--watch}'[watch-mode for given tasks, re-run when inputs change]' \
'(operation)*: :__task_list' \
+ '(operation)' \
{-l,--list}'[list describable tasks]' \
{-a,--list-all}'[list all tasks]' \
{-i,--init}'[create new Taskfile.yml]' \
'(-*)'{-h,--help}'[show help]' \
'(-*)--version[show version and exit]' \
'*: :__task_list'
'(*)'{-l,--list}'[list describable tasks]' \
'(*)'{-a,--list-all}'[list all tasks]' \
'(*)'{-i,--init}'[create new Taskfile.yml]' \
'(- *)'{-h,--help}'[show help]' \
'(- *)--version[show version and exit]' \
}

# don't run the completion function when being source-ed or eval-ed
Expand Down

0 comments on commit 69906b5

Please sign in to comment.