Proof-of-concept of indicating image quality in the song list. #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reads out the image resolution of cover and background files and displays the quality according to some prefined thresholds via colored check marks in the respective song table columns. If the cover images are non-square or the background images are non-16:9-widescreen format, this is additionally indicated by a small exclamation mark on the check mark icon. While this works as expected, it is highly inefficient because the image files are read on the fly. It would probably be better to store the image dimensions in the meta file and simply use that information. The inefficiency is doubled as the image dimensions are determined twice, once to determine the icon to display, a second time to determine the appropriate tooltip.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #209 .
This reads out the image resolution of cover and background files and displays the quality according to some prefined thresholds via colored check marks in the respective song table columns. If the cover images are non-square or the background images are non-16:9-widescreen format, this is additionally indicated by a small exclamation mark on the check mark icon.
While this works as expected, it is highly inefficient because the image files are read on the fly. It would be much better to store the image dimensions in the meta file when downloading and simply use that information.
The inefficiency is doubled as the image dimensions are determined twice, once to determine the icon to display, a second time to determine the appropriate tooltip.