Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use vehicle_data api (BC) #98

Merged
merged 5 commits into from
Apr 30, 2023
Merged

Use vehicle_data api (BC) #98

merged 5 commits into from
Apr 30, 2023

Conversation

andig
Copy link
Collaborator

@andig andig commented Apr 28, 2023 •
edited
Loading

Fix #97

This PR uses the remaining vehicle_data api and renames StateRequest (which never was a request) correspondingly.

TODO:

  • test
  • fix tests
  • examples
  • login

@andig andig changed the title Use vehicle_data api Use vehicle_data api (BC) Apr 28, 2023
@andig andig marked this pull request as draft April 28, 2023 14:09
@thekev thekev mentioned this pull request Apr 28, 2023
Merged
@naltatis naltatis mentioned this pull request Apr 30, 2023
Closed
@andig andig marked this pull request as ready for review April 30, 2023 11:39
@andig
Copy link
Collaborator Author

andig commented Apr 30, 2023 •
edited
Loading

From what I could tell:

  • all getter apis combined into one
  • all data always available (no more pointers)
  • servicedata no longer exists, hence removed (?)

Working according to my tests.

/cc @bogosj could I get an additional confirmation?

@andig andig mentioned this pull request Apr 30, 2023
Merged
@bogosj
Copy link
Owner

bogosj commented Apr 30, 2023

LGTM

@andig andig merged commit 0d6e63e into bogosj:main Apr 30, 2023
@andig andig deleted the fix/api branch April 30, 2023 22:24
@tijszwinkels
Copy link

Works well in my tests. Thanks for quick turnaround guys!

@paede81 paede81 mentioned this pull request May 1, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"data_request" endpoints appear to have been removed by Tesla
3 participants
@andig @bogosj @tijszwinkels