Drop pi-intercom and move oracle/reviewer to Opus 4.8 - #97
Merged
Conversation
Remove npm:pi-intercom from pi_agent_settings_packages. Dropping the extension removes the blocking contact_supervisor tool, fixing the indefinite hang in chain/parallel subagent runs at the root. Switch oracle and reviewer subagents to anthropic/claude-opus-4-8 with high thinking on both work and home hosts. Add opus-4-8 to home's enabledModels so the override resolves there.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughRemoves ChangesConfig updates: package removal and model changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Revert the home host changes from f3e034d. oracle and reviewer return to openai-codex/gpt-5.5 (xhigh), and anthropic/claude-opus-4-8 is removed from home's enabledModels. The work host change is unaffected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Subagents hung indefinitely whenever one called
contact_supervisorduring achain or parallel run. That tool is a blocking intercom ask: the child freezes
waiting for a reply the parent can never send (the parent is itself blocked
inside the
subagent()call, or the ask lands in an exited coordinatorsession). There is no timeout, so the hang is permanent.
Rather than restrict each agent's toolset, this removes the source: dropping
the
pi-intercomextension removes thecontact_supervisor/intercomtoolsentirely, so no agent can issue a blocking ask.
Separately,
oracleandreviewerare promoted to a stronger reasoning model.What
npm:pi-intercomfrompi_agent_settings_packages(group_vars/all.yml).Removes
contact_supervisorglobally — fixes the hang at the root.oracle+reviewer→anthropic/claude-opus-4-8, thinkinghighon both hosts:
work: wasgoogle/gemini-3.1-pro-preview.home: wasopenai-codex/gpt-5.5; also addedanthropic/claude-opus-4-8to
enabledModelsso the override resolves there.Notes
(
ansible-playbook site.yml --limit <host> --tags configs). The settingsmerge is recursive/additive — re-running drops
pi-intercomfrom thegenerated
settings.jsonpackages list.tools:allowlists were intentionally skipped; droppingthe extension makes them redundant.
Summary by CodeRabbit