Skip to content

Commit

Permalink
UX changes for undesirable behaviors and remove top level "All assert…
Browse files Browse the repository at this point in the history
…ions are met" radio option (w3c#319)

* Fix validation for undesirable checkboxes

* Remove top level pass and change checkboxs to one tab stop

* Generate test and review files automatically

Co-authored-by: spectranaut <[email protected]>
  • Loading branch information
spectranaut and spectranaut authored Dec 11, 2020
1 parent 4398954 commit adc6230
Show file tree
Hide file tree
Showing 5 changed files with 241 additions and 203 deletions.
6 changes: 3 additions & 3 deletions index.html
Original file line number Diff line number Diff line change
Expand Up @@ -40,23 +40,23 @@ <h1>Test Patterns for Review</h1>
<td><a href="./tests/checkbox/index.html">Index</a></td>
<td><a href="./review/checkbox.html">Review</a></td>
<td>26</td>
<td><a href="https://github.com/w3c/aria-at/commit/52b50fd" target="_blank">52b50fd Add aria design pattern links to reference.csv(s)
<td><a href="https://github.com/w3c/aria-at/commit/6fb92c0" target="_blank">6fb92c0 Remove top level pass and change checkboxs to one tab stop
</a></td>
</tr>
<tr>
<td>combobox-autocomplete-both</td>
<td><a href="./tests/combobox-autocomplete-both/index.html">Index</a></td>
<td><a href="./review/combobox-autocomplete-both.html">Review</a></td>
<td>30</td>
<td><a href="https://github.com/w3c/aria-at/commit/52b50fd" target="_blank">52b50fd Add aria design pattern links to reference.csv(s)
<td><a href="https://github.com/w3c/aria-at/commit/6fb92c0" target="_blank">6fb92c0 Remove top level pass and change checkboxs to one tab stop
</a></td>
</tr>
<tr>
<td>menubar-editor</td>
<td><a href="./tests/menubar-editor/index.html">Index</a></td>
<td><a href="./review/menubar-editor.html">Review</a></td>
<td>40</td>
<td><a href="https://github.com/w3c/aria-at/commit/52b50fd" target="_blank">52b50fd Add aria design pattern links to reference.csv(s)
<td><a href="https://github.com/w3c/aria-at/commit/6fb92c0" target="_blank">6fb92c0 Remove top level pass and change checkboxs to one tab stop
</a></td>
</tr>
</table>
Expand Down
52 changes: 26 additions & 26 deletions review/checkbox.html
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ <h2>Test 1: Navigate to an unchecked checkbox in reading mode</h2>
<ul>
<li>Mode: reading</li>
<li>Applies to: jaws, nvda</li>
<li>Lasted edited: Wed Dec 2 18:40:34 2020 -0500</li>
<li>Lasted edited: Thu Dec 10 10:41:01 2020 -0800</li>
<li>Tests:
<ul>
<li><a href="../tests/checkbox/test-01-navigate-to-unchecked-checkbox-reading.html?at=jaws">jaws</a></li>
Expand Down Expand Up @@ -260,7 +260,7 @@ <h2>Test 2: Navigate to an unchecked checkbox in interaction mode</h2>
<ul>
<li>Mode: interaction</li>
<li>Applies to: jaws, nvda</li>
<li>Lasted edited: Wed Dec 2 18:40:34 2020 -0500</li>
<li>Lasted edited: Thu Dec 10 10:41:01 2020 -0800</li>
<li>Tests:
<ul>
<li><a href="../tests/checkbox/test-02-navigate-to-unchecked-checkbox-interaction.html?at=jaws">jaws</a></li>
Expand Down Expand Up @@ -326,7 +326,7 @@ <h2>Test 3: Navigate to an unchecked checkbox</h2>
<ul>
<li>Mode: interaction</li>
<li>Applies to: voiceover_macos</li>
<li>Lasted edited: Wed Dec 2 18:40:34 2020 -0500</li>
<li>Lasted edited: Thu Dec 10 10:41:01 2020 -0800</li>
<li>Tests:
<ul>
<li><a href="../tests/checkbox/test-03-navigate-to-unchecked-checkbox-interaction.html?at=voiceover_macos">voiceover_macos</a></li>
Expand Down Expand Up @@ -372,7 +372,7 @@ <h2>Test 4: Navigate to a checked checkbox in reading mode</h2>
<ul>
<li>Mode: reading</li>
<li>Applies to: jaws, nvda</li>
<li>Lasted edited: Wed Dec 2 18:40:34 2020 -0500</li>
<li>Lasted edited: Thu Dec 10 10:41:01 2020 -0800</li>
<li>Tests:
<ul>
<li><a href="../tests/checkbox/test-04-navigate-to-checked-checkbox-reading.html?at=jaws">jaws</a></li>
Expand Down Expand Up @@ -455,7 +455,7 @@ <h2>Test 5: Navigate to a checked checkbox in interaction mode</h2>
<ul>
<li>Mode: interaction</li>
<li>Applies to: jaws, nvda</li>
<li>Lasted edited: Wed Dec 2 18:40:34 2020 -0500</li>
<li>Lasted edited: Thu Dec 10 10:41:01 2020 -0800</li>
<li>Tests:
<ul>
<li><a href="../tests/checkbox/test-05-navigate-to-checked-checkbox-interaction.html?at=jaws">jaws</a></li>
Expand Down Expand Up @@ -531,7 +531,7 @@ <h2>Test 6: Navigate to a checked checkbox</h2>
<ul>
<li>Mode: interaction</li>
<li>Applies to: voiceover_macos</li>
<li>Lasted edited: Wed Dec 2 18:40:34 2020 -0500</li>
<li>Lasted edited: Thu Dec 10 10:41:01 2020 -0800</li>
<li>Tests:
<ul>
<li><a href="../tests/checkbox/test-06-navigate-to-checked-checkbox-interaction.html?at=voiceover_macos">voiceover_macos</a></li>
Expand Down Expand Up @@ -582,7 +582,7 @@ <h2>Test 7: Operate a checkbox in reading mode</h2>
<ul>
<li>Mode: reading</li>
<li>Applies to: jaws, nvda</li>
<li>Lasted edited: Wed Dec 2 18:40:34 2020 -0500</li>
<li>Lasted edited: Thu Dec 10 10:41:01 2020 -0800</li>
<li>Tests:
<ul>
<li><a href="../tests/checkbox/test-07-operate-checkbox-reading.html?at=jaws">jaws</a></li>
Expand Down Expand Up @@ -645,7 +645,7 @@ <h2>Test 8: Operate a checkbox in interaction mode</h2>
<ul>
<li>Mode: interaction</li>
<li>Applies to: jaws, nvda</li>
<li>Lasted edited: Wed Dec 2 18:40:34 2020 -0500</li>
<li>Lasted edited: Thu Dec 10 10:41:01 2020 -0800</li>
<li>Tests:
<ul>
<li><a href="../tests/checkbox/test-08-operate-checkbox-interaction.html?at=jaws">jaws</a></li>
Expand Down Expand Up @@ -706,7 +706,7 @@ <h2>Test 9: Operate a checkbox</h2>
<ul>
<li>Mode: interaction</li>
<li>Applies to: voiceover_macos</li>
<li>Lasted edited: Wed Dec 2 18:40:34 2020 -0500</li>
<li>Lasted edited: Thu Dec 10 10:41:01 2020 -0800</li>
<li>Tests:
<ul>
<li><a href="../tests/checkbox/test-09-operate-checkbox-interaction.html?at=voiceover_macos">voiceover_macos</a></li>
Expand Down Expand Up @@ -748,7 +748,7 @@ <h2>Test 10: Read an unchecked checkbox in reading mode</h2>
<ul>
<li>Mode: reading</li>
<li>Applies to: jaws, nvda</li>
<li>Lasted edited: Wed Dec 2 18:40:34 2020 -0500</li>
<li>Lasted edited: Thu Dec 10 10:41:01 2020 -0800</li>
<li>Tests:
<ul>
<li><a href="../tests/checkbox/test-10-read-unchecked-checkbox-reading.html?at=jaws">jaws</a></li>
Expand Down Expand Up @@ -826,7 +826,7 @@ <h2>Test 11: Read an unchecked checkbox in interaction mode</h2>
<ul>
<li>Mode: interaction</li>
<li>Applies to: jaws, nvda</li>
<li>Lasted edited: Wed Dec 2 18:40:34 2020 -0500</li>
<li>Lasted edited: Thu Dec 10 10:41:01 2020 -0800</li>
<li>Tests:
<ul>
<li><a href="../tests/checkbox/test-11-read-unchecked-checkbox-interaction.html?at=jaws">jaws</a></li>
Expand Down Expand Up @@ -904,7 +904,7 @@ <h2>Test 12: Read an unchecked checkbox</h2>
<ul>
<li>Mode: interaction</li>
<li>Applies to: voiceover_macos</li>
<li>Lasted edited: Wed Dec 2 18:40:34 2020 -0500</li>
<li>Lasted edited: Thu Dec 10 10:41:01 2020 -0800</li>
<li>Tests:
<ul>
<li><a href="../tests/checkbox/test-12-read-unchecked-checkbox-interaction.html?at=voiceover_macos">voiceover_macos</a></li>
Expand Down Expand Up @@ -954,7 +954,7 @@ <h2>Test 13: Read a checked checkbox in reading mode</h2>
<ul>
<li>Mode: reading</li>
<li>Applies to: jaws, nvda</li>
<li>Lasted edited: Wed Dec 2 18:40:34 2020 -0500</li>
<li>Lasted edited: Thu Dec 10 10:41:01 2020 -0800</li>
<li>Tests:
<ul>
<li><a href="../tests/checkbox/test-13-read-checked-checkbox-reading.html?at=jaws">jaws</a></li>
Expand Down Expand Up @@ -1032,7 +1032,7 @@ <h2>Test 14: Read a checked checkbox in interaction mode</h2>
<ul>
<li>Mode: interaction</li>
<li>Applies to: jaws, nvda</li>
<li>Lasted edited: Wed Dec 2 18:40:34 2020 -0500</li>
<li>Lasted edited: Thu Dec 10 10:41:01 2020 -0800</li>
<li>Tests:
<ul>
<li><a href="../tests/checkbox/test-14-read-checked-checkbox-interaction.html?at=jaws">jaws</a></li>
Expand Down Expand Up @@ -1110,7 +1110,7 @@ <h2>Test 15: Read a checked checkbox</h2>
<ul>
<li>Mode: interaction</li>
<li>Applies to: voiceover_macos</li>
<li>Lasted edited: Wed Dec 2 18:40:34 2020 -0500</li>
<li>Lasted edited: Thu Dec 10 10:41:01 2020 -0800</li>
<li>Tests:
<ul>
<li><a href="../tests/checkbox/test-15-read-checked-checkbox-interaction.html?at=voiceover_macos">voiceover_macos</a></li>
Expand Down Expand Up @@ -1160,7 +1160,7 @@ <h2>Test 16: Read grouping information of a grouped checkbox in reading mode</h2
<ul>
<li>Mode: reading</li>
<li>Applies to: jaws, nvda</li>
<li>Lasted edited: Wed Dec 2 18:40:34 2020 -0500</li>
<li>Lasted edited: Thu Dec 10 10:41:01 2020 -0800</li>
<li>Tests:
<ul>
<li><a href="../tests/checkbox/test-16-read-checkbox-group-reading.html?at=jaws">jaws</a></li>
Expand Down Expand Up @@ -1224,7 +1224,7 @@ <h2>Test 17: Read grouping information of a grouped checkbox in interaction mode
<ul>
<li>Mode: interaction</li>
<li>Applies to: jaws, nvda</li>
<li>Lasted edited: Wed Dec 2 18:40:34 2020 -0500</li>
<li>Lasted edited: Thu Dec 10 10:41:01 2020 -0800</li>
<li>Tests:
<ul>
<li><a href="../tests/checkbox/test-17-read-checkbox-group-interaction.html?at=jaws">jaws</a></li>
Expand Down Expand Up @@ -1288,7 +1288,7 @@ <h2>Test 18: Read grouping information of a grouped checkbox</h2>
<ul>
<li>Mode: interaction</li>
<li>Applies to: voiceover_macos</li>
<li>Lasted edited: Wed Dec 2 18:40:34 2020 -0500</li>
<li>Lasted edited: Thu Dec 10 10:41:01 2020 -0800</li>
<li>Tests:
<ul>
<li><a href="../tests/checkbox/test-18-read-checkbox-group-interaction.html?at=voiceover_macos">voiceover_macos</a></li>
Expand Down Expand Up @@ -1332,7 +1332,7 @@ <h2>Test 19: Navigate sequentially through a checkbox group in reading mode</h2>
<ul>
<li>Mode: reading</li>
<li>Applies to: jaws, nvda</li>
<li>Lasted edited: Wed Dec 2 18:40:34 2020 -0500</li>
<li>Lasted edited: Thu Dec 10 10:41:01 2020 -0800</li>
<li>Tests:
<ul>
<li><a href="../tests/checkbox/test-19-navigate-sequentially-through-checkbox-group-reading.html?at=jaws">jaws</a></li>
Expand Down Expand Up @@ -1401,7 +1401,7 @@ <h2>Test 20: Navigate sequentially through a checkbox group</h2>
<ul>
<li>Mode: interaction</li>
<li>Applies to: voiceover_macos</li>
<li>Lasted edited: Wed Dec 2 18:40:34 2020 -0500</li>
<li>Lasted edited: Thu Dec 10 10:41:01 2020 -0800</li>
<li>Tests:
<ul>
<li><a href="../tests/checkbox/test-20-navigate-sequentially-through-checkbox-group-interaction.html?at=voiceover_macos">voiceover_macos</a></li>
Expand Down Expand Up @@ -1447,7 +1447,7 @@ <h2>Test 21: Navigate into a checkbox group in reading mode</h2>
<ul>
<li>Mode: reading</li>
<li>Applies to: jaws, nvda</li>
<li>Lasted edited: Wed Dec 2 18:40:34 2020 -0500</li>
<li>Lasted edited: Thu Dec 10 10:41:01 2020 -0800</li>
<li>Tests:
<ul>
<li><a href="../tests/checkbox/test-21-navigate-into-checkbox-group-reading.html?at=jaws">jaws</a></li>
Expand Down Expand Up @@ -1524,7 +1524,7 @@ <h2>Test 22: Navigate into a checkbox group in interaction mode</h2>
<ul>
<li>Mode: interaction</li>
<li>Applies to: jaws, nvda</li>
<li>Lasted edited: Wed Dec 2 18:40:34 2020 -0500</li>
<li>Lasted edited: Thu Dec 10 10:41:01 2020 -0800</li>
<li>Tests:
<ul>
<li><a href="../tests/checkbox/test-22-navigate-into-checkbox-group-interaction.html?at=jaws">jaws</a></li>
Expand Down Expand Up @@ -1593,7 +1593,7 @@ <h2>Test 23: Navigate into a checkbox group</h2>
<ul>
<li>Mode: interaction</li>
<li>Applies to: voiceover_macos</li>
<li>Lasted edited: Wed Dec 2 18:40:34 2020 -0500</li>
<li>Lasted edited: Thu Dec 10 10:41:01 2020 -0800</li>
<li>Tests:
<ul>
<li><a href="../tests/checkbox/test-23-navigate-into-checkbox-group-interaction.html?at=voiceover_macos">voiceover_macos</a></li>
Expand Down Expand Up @@ -1643,7 +1643,7 @@ <h2>Test 24: Navigate out of a checkbox group in reading mode</h2>
<ul>
<li>Mode: reading</li>
<li>Applies to: jaws, nvda</li>
<li>Lasted edited: Wed Dec 2 18:40:34 2020 -0500</li>
<li>Lasted edited: Thu Dec 10 10:41:01 2020 -0800</li>
<li>Tests:
<ul>
<li><a href="../tests/checkbox/test-24-navigate-out-of-checkbox-group-reading.html?at=jaws">jaws</a></li>
Expand Down Expand Up @@ -1712,7 +1712,7 @@ <h2>Test 25: Navigate out of a checkbox group in interaction mode</h2>
<ul>
<li>Mode: interaction</li>
<li>Applies to: jaws, nvda</li>
<li>Lasted edited: Wed Dec 2 18:40:34 2020 -0500</li>
<li>Lasted edited: Thu Dec 10 10:41:01 2020 -0800</li>
<li>Tests:
<ul>
<li><a href="../tests/checkbox/test-25-navigate-out-of-checkbox-group-interaction.html?at=jaws">jaws</a></li>
Expand Down Expand Up @@ -1781,7 +1781,7 @@ <h2>Test 26: Navigate out of a checkbox group</h2>
<ul>
<li>Mode: interaction</li>
<li>Applies to: voiceover_macos</li>
<li>Lasted edited: Wed Dec 2 18:40:34 2020 -0500</li>
<li>Lasted edited: Thu Dec 10 10:41:01 2020 -0800</li>
<li>Tests:
<ul>
<li><a href="../tests/checkbox/test-26-navigate-out-of-checkbox-group-interaction.html?at=voiceover_macos">voiceover_macos</a></li>
Expand Down
Loading

0 comments on commit adc6230

Please sign in to comment.