Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add running voiceover on chrome and firefox #26

Merged
merged 17 commits into from
Jul 22, 2024
Merged

Add running voiceover on chrome and firefox #26

merged 17 commits into from
Jul 22, 2024

Conversation

outofambit
Copy link
Collaborator

@outofambit outofambit commented Jul 22, 2024 •
edited
Loading

This PR addresses w3c/aria-at-app#1171

@outofambit outofambit marked this pull request as ready for review July 22, 2024 19:57
@outofambit outofambit requested a review from gnarf July 22, 2024 20:03
gnarf
gnarf reviewed Jul 22, 2024
View reviewed changes
run-tester.sh Outdated Show resolved Hide resolved
gnarf
gnarf approved these changes Jul 22, 2024
View reviewed changes
Copy link
Collaborator

@gnarf gnarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that the comment I made >must< be addressed now, but if you know a way to handle it quickly, it might be nice to not have the top of this run spammed with the output from curl debug

@gnarf gnarf merged commit e476836 into main Jul 22, 2024
1 check passed
@gnarf gnarf deleted the add-vo-chrome-firefox branch July 22, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnarf gnarf gnarf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@outofambit @gnarf