When an interface has unexported methods, adding a method is minor, not major #29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you add a new method to a type, that's a minor-version change: safe for existing callers to use, but providing new behavior for new code that wants to use it.
But when you add a new method M to an interface, it's a major-version change. Why? Because a caller may have defined its own type T implementing the interface, and if they upgrade, T no longer does unless and until it implements M.
However! Some interfaces are not meant to be implemented outside of the modules in which they're defined. Case in point: EnumDescriptor. It prevents callers from implementing that interface by including an unexported method.
Adding a method to such an interface cannot break calling code, and so is not a major-version change.
This PR demotes a method-added-to-an-interface change from Major to Minor in the specific case where the interface in question contains unexported methods and/or is defined in terms of "internal" types that callers cannot access.
Fixes #28.