Cache the result of comparer.identical for a massive speedup. (#26)

bobg · Jun 6, 2024 · 16a7d9c · 16a7d9c
1 parent 79d9c58
commit 16a7d9c
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 4 deletions.
diff --git a/identical.go b/identical.go
@@ -3,7 +3,13 @@ package modver
 import "go/types"
 
 // https://golang.org/ref/spec#Type_identity
-func (c *comparer) identical(a, b types.Type) bool {
+func (c *comparer) identical(a, b types.Type) (res bool) {
+	tp := typePair{a: a, b: b}
+	if res, ok := c.identicache[tp]; ok {
+		return res
+	}
+	defer func() { c.identicache[tp] = res }()
+
 	if types.Identical(a, b) {
 		return true
 	}

diff --git a/types.go b/types.go
@@ -12,14 +12,18 @@ import (
 
 type (
 	comparer struct {
-		stack []typePair
-		cache map[typePair]Result
+		stack       []typePair
+		cache       map[typePair]Result
+		identicache map[typePair]bool
 	}
 	typePair struct{ a, b types.Type }
 )
 
 func newComparer() *comparer {
-	return &comparer{cache: make(map[typePair]Result)}
+	return &comparer{
+		cache:       make(map[typePair]Result),
+		identicache: make(map[typePair]bool),
+	}
 }
 
 func (c *comparer) compareTypes(older, newer types.Type) (res Result) {