Conversation
InoMurko
force-pushed
the
inomurko/bump-bundler-2
branch
5 times, most recently
from
8794c88 to
a589698
Compare
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v3 | ||
| - name: Setup Node | ||
| uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: '16.x' | ||
| registry-url: 'https://registry.npmjs.org' | ||
| - name: Install dependencies and build 🔧 | ||
| run: yarn install --frozen-lockfile --legacy-peer-deps && yarn run build | ||
| - name: Publish package on NPM 📦 | ||
| working-directory: ./packages/boba/bundler_sdk | ||
| run: npm publish --access public | ||
| env: | ||
| NODE_AUTH_TOKEN: ${{ secrets.NPM_BOBA_FOUNDATION }} |
There was a problem hiding this comment.
this probably takes "version": "0.2.3", from the package.json, right?
is there a way to prevent overwriting packages in NPM?
something like this: ethereum-optimism/optimism#5413 (comment)
There was a problem hiding this comment.
with the current configuration we only create a new package on new "Github release", not on new commit to a specific branch. So yes, right now we would need to update the version number of package.json.
If you keep the same version number in the package.json then the release simply fails, and is not released. Basically npmjs.org prevents you from overwriting existing packages.
There was a problem hiding this comment.
okay, makes sense. thats good to know.
should we address the second part of my comment separately - the automation (changeset PRs)?
There was a problem hiding this comment.
let's do it in a separate issue / PR because I guess we also might need to add a version check to avoid failing releases if possible (or auto-incrementing the version number etc).
There was a problem hiding this comment.
if we do auto-increment for the version, then we maybe could also consider releasing on commit (with changeset) as in your screenshot above.
There was a problem hiding this comment.
yeah, one by one! open an issue pls!
There was a problem hiding this comment.
|
Please clean the commit history |
wsdt
force-pushed
the
wsdt/bundlersdk-ci-pipeline
branch
from
82a1de1 to
6b8933b
Compare
(cherry picked from commit 718141f)
* Inomurko/bump bundler (#698) * bump bundler, limit dependency bumps * uncomment bundler related stuff * build bundler in docker * build fixes * fix tests * fix bundler building * uncomment _disableInitializers * fix running DTL * v1.0.0 * fixing starting bundler and tests, default config * local unsafe, linting fix in intg tests * custom errors fixes * new api for simple account contract * use simple account factory proxy * use simple account factory proxy in SimpleAccountAPI * use simple account factory proxy in SimpleAccountAPI * use wrappers to get around custom errors * update entrypoint wrapper (#745) * sponsoring fee fixed * stricter validation for staking * remove debug namespace, fix return for unaavailable rpc methods * addressing Souradeeps comments --------- Co-authored-by: Souradeep Das <dsouradeep2@gmail.com> (cherry picked from commit 6368c72) * fix: qsp30 (#773) fix: BOB1-30 (cherry picked from commit 7feda88) * run op fix (#771) (cherry picked from commit 176cd3c) * close-server (#768) (cherry picked from commit 72021af) * [AA]: fix inconsistent userOpHash (#757) * add token callback handler on SimpleAccount * fix: userOpHash packing * prevent recursive calls into handleOps * move nonce validation from individual Account to EntryPoint * add bundler changes for nonce change to EP (cherry picked from commit cc4e205) * ValidationManager account for signature expiration (#775) * resolve #753 * Update packages/boba/bundler/src/modules/ValidationManager.ts Co-authored-by: Ino Murko <ino.murko.github@protonmail.com> * fix bool * validAfter/Until integrationt tests, validAfter * cleanup * regex * integration_tests * integration & unit tests --------- Co-authored-by: Ino Murko <ino.murko.github@protonmail.com> (cherry picked from commit ef02bee) * npm release workflow for bundler-sdk (#749) (cherry picked from commit 718141f) * Fix/banxa and bridges (#772) * adding boba network * fixing boba bridge url * fixing bridge integration * replace code by selectors * remove hardcoded symbol * enable banxa only for mainnet * Available bridge inable only for mainnet * adding support for testnet * update conditional for other bridges * implemented the available bridges with typescript * unit test cases for available bridges * typo in Available bridges --------- Co-authored-by: alvaro-ricotta <alvaro.e.ricotta@gmail.com> Co-authored-by: alvaro-ricotta <81116391+alvaro-ricotta@users.noreply.github.com> Co-authored-by: Ino Murko <ino.murko.github@protonmail.com> (cherry picked from commit dcf9b7e) * add validation of entryPoint and wrapper (#779) * add validaiton of entryPoint and wrapper (cherry picked from commit 41f3150) --------- Co-authored-by: Souradeep Das <dsouradeep2@gmail.com> Co-authored-by: Riedl Kevin, Bsc <kevin.riedl@wavect.io> Co-authored-by: Sahil K <86316370+sk-enya@users.noreply.github.com>
3 participants
Overview
Add CI/CD pipeline for
@bobanetwork/bundler_sdk.resolves #739
Changes
@bobato@bobanetworkas the scope on npmjs is unfortunately already taken & refactored usages (but didn't do so for other packages yet - TBD)Testing
Test run of pipeline successful. Test package has been deleted from the registry.