Skip to content

Add wallet auto connection#647

Merged
boyuan-chen merged 6 commits intofeat/wallet-connectfrom
feat/auto-connection
Mar 10, 2023
Merged

Add wallet auto connection#647
boyuan-chen merged 6 commits intofeat/wallet-connectfrom
feat/auto-connection

Conversation

@boyuan-chen
Copy link
Copy Markdown
Contributor

📋 Add associated issues, tickets, docs URL here.

Overview

Describe what your Pull Request is about in a few sentences.

Remove the logic of refreshing the window if users switch chains.

Note: window is refreshed only when accounts are changed. This can be improved too, but it depends on how urgent it is.

Changes

Describe your changes and implementation choices. More details make PRs easier to review.

  • Add disconnection button
  • Add logic of firing initializeBase and initializeAccount when the chain id is changed

Testing

Describe how to test your new feature/bug fix and if possible, a step by step guide on how to demo this.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 9, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (61e6ca6) 48.51% compared to head (673874b) 48.51%.

❗ Current head 673874b differs from pull request most recent head 8952dcf. Consider uploading reports for the commit 8952dcf to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@                 Coverage Diff                  @@
##           feat/wallet-connect     #647   +/-   ##
====================================================
  Coverage                48.51%   48.51%           
====================================================
  Files                      132      132           
  Lines                     5551     5551           
  Branches                  1123     1123           
====================================================
  Hits                      2693     2693           
  Misses                    2858     2858           
Flag Coverage Δ
coverage 48.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sk-enya sk-enya requested review from sk-enya, wavect-gmbh and wsdt March 9, 2023 14:48
@sk-enya sk-enya linked an issue Mar 9, 2023 that may be closed by this pull request
Comment thread packages/boba/gateway/src/actions/setupAction.js
Comment thread packages/boba/gateway/src/actions/setupAction.js
@boyuan-chen boyuan-chen merged commit 47c0f7d into feat/wallet-connect Mar 10, 2023
@boyuan-chen boyuan-chen deleted the feat/auto-connection branch March 10, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Gateway]: One-gateway known issues.

4 participants