Remove use of Etherscan on client to fetch transactions#541
Merged
Conversation
boyuan-chen
approved these changes
Jan 27, 2023
InoMurko
approved these changes
Jan 27, 2023
InoMurko
pushed a commit
that referenced
this pull request
Feb 2, 2023
(cherry picked from commit 3d2b9d1)
InoMurko
pushed a commit
that referenced
this pull request
Feb 2, 2023
(cherry picked from commit 3d2b9d1)
Merged
InoMurko
added a commit
that referenced
this pull request
Feb 2, 2023
* Validation for uploaded DTL address lists (#538) (cherry picked from commit 733276c) * change: remove use etherscan on client to fetch unrelative txs (#541) (cherry picked from commit 3d2b9d1) * Revert "patch proxyd validId (#543)" (#547) This reverts commit aa4a7fd. (cherry picked from commit fabbf36) * Add gascap and check input on hybrid compute and add unit tests (#553) (cherry picked from commit 61b1e85) Co-authored-by: cby3149 <cby3149@gmail.com> (cherry picked from commit abf05cc) --------- Co-authored-by: Michael Montour <83612658+mmontour1306@users.noreply.github.com> Co-authored-by: Sahil K <86316370+sk-enya@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📋 Add associated issues, tickets, docs URL here.
Closes: https://github.com/bobanetwork/boba/issues/540
Overview
Free Etherscan Api Key is getting exposed on the gateway which we are using to fetch the Txs.
Changes
As we don't need to show transactions which is not related to boba like
transfer of ETH from L1 to another walletso we can remove it as we already have the monitoring and watcher services in place to fetch the required transactionsTesting