Skip to content

fix: add-babylons#482

Closed
yecandir wants to merge 1 commit intobobanetwork:developfrom
yecandir:add-babylons
Closed

fix: add-babylons#482
yecandir wants to merge 1 commit intobobanetwork:developfrom
yecandir:add-babylons

Conversation

@yecandir
Copy link
Copy Markdown

Add babylons to ecosystem

@sk-enya
Copy link
Copy Markdown
Contributor

sk-enya commented Dec 6, 2022

@yecandir can you please resolve conflict.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 6, 2022

Codecov Report

Base: 44.74% // Head: 74.61% // Increases project coverage by +29.86% 🎉

Coverage data is based on head (2f3e060) compared to base (d858381).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #482       +/-   ##
============================================
+ Coverage    44.74%   74.61%   +29.86%     
============================================
  Files          106       64       -42     
  Lines         4253     1926     -2327     
  Branches       847      321      -526     
============================================
- Hits          1903     1437      -466     
+ Misses        2350      489     -1861     
Flag Coverage Δ
boba-contracts ?
contracts 79.30% <ø> (ø)
core-utils 86.80% <ø> (ø)
data-transport-layer 31.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...racts/contracts/oracle/SimplePriceFeedRegistry.sol
...ckages/boba/contracts/contracts/ERC721Registry.sol
...ba/contracts/contracts/lzTokenBridge/EthBridge.sol
.../contracts/contracts/DAO/governance-token/BOBA.sol
packages/boba/contracts/contracts/AtomicSwap.sol
...boba/contracts/contracts/libraries/SafeMathDAO.sol
.../contracts/contracts/L1MultiMessageRelayerFast.sol
...contracts/DAO/governance/GovernorBravoDelegate.sol
...contracts/lzTokenBridge/lzApp/NonblockingLzApp.sol
...racts/contracts/ERC1155Bridges/L2ERC1155Bridge.sol
... and 32 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@boyuan-chen
Copy link
Copy Markdown
Contributor

@yecandir Could you please fix the conflict?

"telegram": "https://t.me/babylonsnft",
"twitter": "https://twitter.com/BabylonsNFT",
"discord": "https://discord.com/invite/babylonsnft",
"type": "NFT Marketplace and web3.0 Infrastructure Services",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yecandir value of type should be between the list below

const typeOrder = ['defi', 'gamefi', 'nft', 'bridge', 'wallet', 'tool', 'token']

So it will be visible on ecosystem page.

@sk-enya
Copy link
Copy Markdown
Contributor

sk-enya commented Jan 16, 2023

Closing this as updated changes with PR https://github.com/bobanetwork/boba/pull/518

@sk-enya sk-enya closed this Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants