Skip to content

[Gateway Patch] : Patch for sentry issues on mainnet.#468

Merged
sk-enya merged 8 commits intorelease/v0.2.2from
sahil/fix-sentry-errors
Nov 21, 2022
Merged

[Gateway Patch] : Patch for sentry issues on mainnet.#468
sk-enya merged 8 commits intorelease/v0.2.2from
sahil/fix-sentry-errors

Conversation

@sk-enya
Copy link
Copy Markdown
Contributor

@sk-enya sk-enya commented Nov 21, 2022

📋 Add associated issues, tickets, docs URL here.

https://github.com/bobanetwork/boba/issues/467

Overview

Fixes for the Mainnet Gateway issues reported on sentry.

Changes

Describe your changes and implementation choices. More details make PRs easier to review.

  • Updated sentry react and tracing packages to latest version
  • Deprecated Airdrop as services has been throwing an error 501
  • Move all Dao related fetch calls to DAO container.
  • Fix threshold check on create new proposal DAO.
  • Clean up home container and consoles
  • Fix rate limiting on gateway with fetchGas only on interval instead of each render. https://github.com/bobanetwork/boba/pull/469

Testing

  • Airdrop option is not visible on gateway.
  • Airdrop Error Error won't be reported on sentry

@sk-enya sk-enya marked this pull request as draft November 21, 2022 17:11
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 21, 2022

Codecov Report

❗ No coverage uploaded for pull request base (release/v0.2.2@ba15360). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@                Coverage Diff                @@
##             release/v0.2.2     #468   +/-   ##
=================================================
  Coverage                  ?   47.79%           
=================================================
  Files                     ?       97           
  Lines                     ?     3825           
  Branches                  ?      763           
=================================================
  Hits                      ?     1828           
  Misses                    ?     1997           
  Partials                  ?        0           
Flag Coverage Δ
boba-contracts 20.58% <0.00%> (?)
contracts 79.30% <0.00%> (?)
core-utils 86.80% <0.00%> (?)
data-transport-layer 31.17% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

 - moved dao related fetch calls to dao container
 - clean up home container
 - fix threshold check on create new proposal.
@sk-enya sk-enya marked this pull request as ready for review November 21, 2022 18:47
Copy link
Copy Markdown
Contributor

@boyuan-chen boyuan-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sk-enya sk-enya merged commit 74fa6e6 into release/v0.2.2 Nov 21, 2022
@sk-enya sk-enya deleted the sahil/fix-sentry-errors branch November 21, 2022 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants